Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing await and increase polling delay #1300

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Dec 29, 2022

“I was thinking of the immortal words of Socrates when he said... I drank what?”

Mitigates some of the the rate limiting issues of #1255, although the upstream cause seems to be related to octokit/plugin-throttling.js#454

> _“I was thinking of the immortal words of Socrates when he said... I drank what?”_
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working cml-runner Subcommand labels Dec 29, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team December 29, 2022 18:46
@0x2b3bfa0 0x2b3bfa0 self-assigned this Dec 29, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 29, 2022 18:46 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@omesser omesser self-requested a review December 29, 2022 19:06
@0x2b3bfa0 0x2b3bfa0 merged commit 45e32bd into master Dec 29, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the misssing-await branch December 29, 2022 19:13
@0x2b3bfa0 0x2b3bfa0 linked an issue Dec 30, 2022 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cml-runner Subcommand
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-hosted runners terminated prematurely
2 participants